Potential fix for code scanning alert no. 1: Missing Dispose call on local IDisposable#21
Merged
seesharprun merged 1 commit intomainfrom Mar 19, 2026
Merged
Potential fix for code scanning alert no. 1: Missing Dispose call on local IDisposable#21seesharprun merged 1 commit intomainfrom
seesharprun merged 1 commit intomainfrom
Conversation
…local IDisposable Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Sidney Andrews <sidandrews@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the passwordless Cosmos DB connection sample to properly dispose the CosmosClient, addressing a code scanning alert about a missing Dispose call.
Changes:
- Switches
CosmosClientinstantiation to ausingdeclaration to ensure deterministic disposal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/AzureCosmosDB/samples/security/code-scanning/1
In general, the correct fix is to ensure that any object implementing
IDisposableis disposed, preferably via ausingstatement/usingdeclaration so that disposal happens automatically when the scope ends, even if exceptions occur. For a short, top-level sample like this, the most straightforward change is to wrap theCosmosClientcreation in ausingdeclaration so that it is disposed when the program reaches the end of the top-level scope.Concretely, in
dotnet/001-connect-passwordless/connect.cs, change the line that createsclientfrom a plainvar client = new CosmosClient(endpoint, credential);to ausing var client = new CosmosClient(endpoint, credential);. This keeps all existing behavior the same while ensuringDisposeis called when the top-level statements complete. No additional methods or imports are required;using varis a C# language feature andCosmosClientalready implementsIDisposable.Suggested fixes powered by Copilot Autofix. Review carefully before merging.